Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit installing dependency error #130

Closed
wants to merge 1 commit into from
Closed

Conversation

shunsukew
Copy link
Contributor

Fix #55
Or was it intentional?

@shunsukew shunsukew requested a review from codespool March 28, 2023 01:58
@codespool
Copy link
Collaborator

This was actually intentional.
Reasoning:

  • only yarn/npm i command failed for some reason
  • everything else is processed and copied.
  • yarn install can be run/debugged manually
  • exiting early will skip creating the swanky.config, so the project will be useless and the whole process should be reverted (delete the folder)

As I see it there are 2 options:

  • delete everything and fail/abort
  • finish instantiating the project and notify the user to run yarn on their own

@shunsukew
Copy link
Contributor Author

shunsukew commented Mar 28, 2023

I see,
When node version is low (e.g. 16.x.x), install dependency process fails. it is good to warn finishing installation by using yarm/npm.
I close PR for now

@shunsukew shunsukew closed this Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

init command should fail when having dependency installation error
2 participants